AllTheMods / Server-Scripts

Server Startup Scripts
Other
68 stars 38 forks source link

Add java path setting #41

Closed jasperfirecai2 closed 5 years ago

jasperfirecai2 commented 5 years ago

I often found myself having to manually replace all the "java" calls in scripts like these because of a bad java install location, so i made it an option. i'm not 100% confident about the linux implementation, but the batch script works like a charm. Please let me know if you would like me to make a new pull request with only the batch script and settings.cfg.

Only other thing i've changed is removing the -d64 java flag, because it doesn't do anything unless running on solaris OS. (source)

FallenEagle1 commented 5 years ago

If still wanted, probably remade as some changes were put in for other issues, so now there are some conflicts needing resolved. As for the -d64 part, it's mainly to make sure that the script checks that 32 bit is not being tried at all. Minecraft technically used to be able to run on 32 (still might, haven't specifically tested lately) but most modpacks need more memory than what 32 bit allows, so just not letting it be a potential option.