search

AllTheMods / Server-Scripts

Server Startup Scripts
Other
68 stars 37 forks source link

ServerStart.bat endless loops install for forge-1.12.2-14.23.5.2854 (and possibly others) - fix #73

Open wideblaze opened 4 years ago

wideblaze commented 4 years ago

serverstart.log: https://pastebin.com/jUa151tq

forge server (at least in forge-1.12.2-14.23.5.2854) does not contain universal in jar name: https://prnt.sc/sud5b0

thus fails check on line 472 and executes INSTALLSTART

work around: removing "universal" from line 472 `IF NOT EXIST "%~dp0forge%MC_SERVER_FORGEVER%universal*.jar" (`

to

IF NOT EXIST "%~dp0*forge*%MC_SERVER_FORGEVER%*.jar" (

fixes endless loop issue

thank you to my discord users: jellejurre for debugging/work around ,C-Moon for logs, and Zero for testing fix.

wideblaze commented 4 years ago

likely related issues:: #67 and #70

YoYoK3nny commented 2 years ago

work around: removing "universal" from line 472 `IF NOT EXIST "%~dp0forge%MC_SERVER_FORGEVER%universal*.jar" (`

to

IF NOT EXIST "%~dp0*forge*%MC_SERVER_FORGEVER%*.jar" (

fixes endless loop issue

Remove the last asterisk, otherwise the check matches against the installer jar: IF NOT EXIST "%~dp0*forge*%MC_SERVER_FORGEVER%.jar" (

This workaround is fine for newer versions, but not older versions (switches the target of the install-loop to older versions)