...the Forge file name is "assumed" to match a standard format. This failes for example with Forge 1614 for 1.7.10 because the filename has an extra "1.7.10" in it: forge-1.7.10-10.13.4.1614-1.7.10-universal.jar
In the BAT version I do wildcard pattern match so it's pretty robust at finding the correct name. However, for the URL I grab the html page and then search the text of the html for a string that matches the pattern (kinda regex) which is an entire step the bash version is not doing.
We could at least do it for the jar on the filesystem like: java -jar forge*{mcver}*{forgever}*.jar
While I might be inclined to say "we don't support 1.7 it's too old" this could potentially be a future issue if forge changes their naming convention slightly in the future, too.
@Dijkstra1 Regarding: The download... https://github.com/AllTheMods/Server-Scripts/blob/master/ServerStart.sh#L67
and JAR launch... https://github.com/AllTheMods/Server-Scripts/blob/master/ServerStart.sh#L117
...the Forge file name is "assumed" to match a standard format. This failes for example with Forge 1614 for 1.7.10 because the filename has an extra "1.7.10" in it:
forge-1.7.10-10.13.4.1614-1.7.10-universal.jarIn the BAT version I do wildcard pattern match so it's pretty robust at finding the correct name. However, for the URL I grab the html page and then search the text of the html for a string that matches the pattern (kinda regex) which is an entire step the bash version is not doing.
We could at least do it for the jar on the filesystem like:
java -jar forge*{mcver}*{forgever}*.jarWhile I might be inclined to say "we don't support 1.7 it's too old" this could potentially be a future issue if forge changes their naming convention slightly in the future, too.