AllTheMods / Server-Scripts

Server Startup Scripts
Other
68 stars 37 forks source link

Java path that involved in version-check in startserver.bat cannot be modified in setting.cfg #96

Open MUYUTwilighter opened 12 months ago

MUYUTwilighter commented 12 months ago

In code block :CHECKJAVA in startserver.bat, line 302 and 304, the flag -d64 does not seem to be supported by the Azule Open JDK 17, which causing error that cannot be resolved via modifying the setting.cfg file.

If I replace java with PATH_TO_CORRECT_JAVA, the script will run successfully. But it's complicated to find and modify.

My machine is not only running Minecraft server but also running other services that rely on default java 17, so it would bring extra work on me if I modify default java version. Although I do have installed java 8, I have to modify startserver.bat while it's not suggested by the readme.

Here's the log

Consider offering users an option to customize java path. One way that may work

REM somewhere in beginning of the startserver.bat file
JAVA_PATH = Path/to/java.exe

REM line 302 and 304 in startserver.bat file
JAVA_PATH -d64 -version blablabla

Other information: My Machine: Windows 11 x64 on a x86 CPU Default Java incompatible with the script: Azule Open JDK 17.0.7 Modpack: E2E for MC 1.12.2