AllTheMods / VolcanoBlock

A skyblock but in Lava?!
5 stars 8 forks source link

trying to extract lava from a mekanism tank connected to pipez corrupts the game save #118

Open GridCube opened 1 year ago

GridCube commented 1 year ago

trying to extract lava from a mekanism tank using either a bucket or another mekanism tank causes the game to crash and then fail to launch from then on, the tank is connected to a create pulley by fluid Pipez

a few crash reports crash-2023-08-28_21.36.00-server.txt crash-2023-08-28_20.10.31-server.txt crash-2023-08-28_20.14.18-server.txt crash-2023-08-28_20.16.02-server.txt crash-2023-08-28_21.29.21-server.txt crash-2023-08-28_21.31.40-server.txt 2023-08-28_21 45 55

Oscaz commented 1 year ago

Just encountered the same issue -- its caused by fluid being null in this function in com.simibubi.create.content.fluids.transfer.FluidManipulationBehaviour

    protected void playEffect(Level world, BlockPos pos, Fluid fluid, boolean fillSound) {
+       if (fluid == null) return;
        BlockPos splooshPos = pos == null ? blockEntity.getBlockPos() : pos;
        FluidStack stack = new FluidStack(fluid, 1);

        SoundEvent soundevent = fillSound ? FluidHelper.getFillSound(stack) : FluidHelper.getEmptySound(stack);
        world.playSound(null, splooshPos, soundevent, SoundSource.BLOCKS, 0.3F, 1.0F);
        if (world instanceof ServerLevel)
            AllPackets.sendToNear(world, splooshPos, 10, new FluidSplashPacket(splooshPos, stack));
    }

I fixed it by adding a catch case and just leaving it at that -- there should probably be a more proper fix probably further up the chain, but this is working for me for now, so feel free to just use it for now. Obligatory take a backup, no warranty provided, my fix is provided as-is.

https://files.oscaz.dev/create-1.19.2-0.5.1.b.jar

As a general rule, don't download software from random strangers on the interwebs. If you can, clone the Create mod repo at commit 1c30b235 as I did, add the fix and recompile.

GridCube commented 1 year ago

i tried to change the pipe for a laserio node and it crashed the game as well crash-2023-09-02_13.18.47-server.txt