AllThingsSmitty / css-protips

⚡️ A collection of tips to help take your CSS skills pro 🦾
Creative Commons Zero v1.0 Universal
28.34k stars 2.17k forks source link

added css pro-tips for ('margins') #179

Open AdebayoIbrahim opened 1 year ago

AdebayoIbrahim commented 11 months ago

Done As Requested!

On Fri, 1 Dec 2023 at 06:32, Jesus Torres @.***> wrote:

@.**** requested changes on this pull request.

Only lines that should be changed / included should be for your margin CSS work don't change any prior existing code please

In README.md https://github.com/AllThingsSmitty/css-protips/pull/179#discussion_r1411628133 :

:empty {
display: none;
}

+### Use margin-inline to add margin to both right and left of an html element,moreover when you want to set margin to top and bottom with same value use the shorthand margin-block

lines 605 through 615 should be the only lines being included your pr is modifying a lot of lines please adjust this and resubmit

In README.md https://github.com/AllThingsSmitty/css-protips/pull/179#discussion_r1411628896 :

:empty {
display: none;
}

+### Use margin-inline to add margin to both right and left of an html element,moreover when you want to set margin to top and bottom with same value use the shorthand margin-block

cause of changes could be auto format setup in your IDE I'd start their

— Reply to this email directly, view it on GitHub https://github.com/AllThingsSmitty/css-protips/pull/179#pullrequestreview-1759046633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXO3HMVQPCKU4ZZC2YBBZGTYHFTW7AVCNFSM6AAAAAA2N4BFBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJZGA2DMNRTGM . You are receiving this because you authored the thread.Message ID: @.***>