Added error event propagation for conversion.

AllToMP3 / alltomp3

Node module to download and convert in MP3 with tags an online video

GNU Affero General Public License v3.0

142 stars 36 forks source link

Added error event propagation for conversion. #27

Closed andrasore closed 5 years ago

andrasore commented 5 years ago

Hello! When ffmpeg-fluent fails for some reason, the resulting error event won't get handled, and an error is thrown. I added an error handler so the download process won't halt as a consequence of this error.

This should almost fix AllToMP3/alltomp3-app#129: with the patch, only the error'd tracks will be skipped.

ghost commented 4 years ago

This looks like good news! But could anyone please explain in layman terms what I have to do to patch the original files (I'm on windows 10). The only "index.js" file I found is located in C:......\AppData\Local\Programs\AllToMP3\resources\app.asar.unpacked\node_modules\sharp\lib\index.js

Upon inspection it looks like a completely different file. Replacing it predictably didn't work. My program version is 0.3.11.128

NTag commented 4 years ago

I finally released a new version of the app (0.3.12), including this fix.

Luigi594 commented 4 years ago

You didn't do nothing, the problem still there