search

AllYarnsAreBeautiful / ayab-desktop

The AYAB Software
http://ayab-knitting.com
GNU General Public License v3.0
60 stars 31 forks source link

Incorrect needle selection on 270, after starting AYAB with the carriage to the right of the left hall sensor. #667

Open Adrienne200 opened 4 months ago

Adrienne200 commented 4 months ago

270 only. If you click Cancel, then Knit, while to the right of the left Hall sensor, AYAB appears to start up correctly, but it the "shadows", coping the pattern again when it shouldn't.

AYAB software version: 0.99.0-rc6 Computer/OS: Intel Mac, Big Sur Knitting machine: KH270 AYAB hardware: Interface

Steps

  1. Make sure that you have AYAB's prefs set to 270, and have flashed the firmware
  2. Use any non-repeating image, sample attached.
  3. First test the image by air-knitting the conventional steps, placing the carriage outside the left turn mark, click Knit, cross the turn mark, wait a moment, continue. This should just work.
  4. Now, stop the carriage anywhere to the right of the left turn mark.
  5. Click Cancel. Then click Knit
  6. Move the carriage from right to left so that both magnets are to the left of the left turn mark
  7. Take the carriage across the turn mark from left to right, wait a moment, continue.

Expected: It should start again at row 1, and just work. (Having ignored all right-left magnet movements) Actual: It repeats the pattern twice.

abcd vertical 32x64

it's supposed to ignore the right-left movement and

clholgat commented 3 months ago

Oh, I know what this is. There's an early out for the 270 carriage detection because of the two magnets, it's probably causing problems.

dl1com commented 3 months ago

Oh, I know what this is. There's an early out for the 270 carriage detection because of the two magnets, it's probably causing problems.

Do you think this is a trivial fix and can make it into 1.0 or should be postponed?

X-sam commented 3 months ago

Is this related to https://github.com/AllYarnsAreBeautiful/ayab-firmware/issues/179

jonathanperret commented 1 month ago

Is this related to AllYarnsAreBeautiful/ayab-firmware#179

Right, this should probably be tested again.

dl1com commented 1 week ago

According to @Adrienne200 s report in Discord, still not fixed (also incorporating with https://github.com/AllYarnsAreBeautiful/ayab-firmware/pull/207 )

clholgat commented 1 week ago

I can repro locally. Digging

clholgat commented 1 week ago

Well, that was easy https://github.com/AllYarnsAreBeautiful/ayab-firmware/pull/208

jonathanperret commented 6 days ago

Fix is included in https://github.com/AllYarnsAreBeautiful/ayab-desktop/releases/tag/1.0.0-beta3 but a round of testing would be nice before closing this.