AllYarnsAreBeautiful / ayab-desktop

The AYAB Software
http://ayab-knitting.com
GNU General Public License v3.0
56 stars 31 forks source link

[BUG] Flanking needles get a extra row in Classic and HoP variants of DBJ. #690

Open Adrienne200 opened 1 month ago

Adrienne200 commented 1 month ago

2-colors works as expected in all methods, and Middle-Twice now works correctly in 3+ colors, so I'm closing #231, and describing Classic and HoP here.

AYAB software version: 0.99.0-20240725-no-start-delay. (This is an interim build after RC6. Recent changes have no bearing on this behavior) Computer/OS: Intel Mac, Big Sur 11.7.10 Knitting machine: KH910 AYAB hardware: shield

Flanking needles take two forms. One is if you tell the software to use a few more needles than the width of the image. The second is if you actually use even more needles that you haven't told the software about. Ideally they both knit in the background (white) yarn. Currently in Classic and HoP both kinds of flanking needles get an extra row. You can see the wrong behavior of the first kind in Simulation, to see the second kind you have to actually knit.

Ribber-Classic:

  1. Load up a 3-color image. I used the Mushroom sample, which is 3 colors and 36 pixels wide, L18-R18.
  2. Select Ribber:Classic and 3 colors
  3. Tell it you're using needles L21-R21
  4. Bring needles L25-R25 into work.
  5. Cast on and knit in DBJ.
  6. Also do Simulate.

Expected: Both sets of flanking needles (19-21 that the software knows about, and 22-25 that it doesn't) should knit in white, once per row. Actual: Both sets of flanking needles knit twice, once in white and once in the next color in the sequence. So the edges are twice as tall, and have an unwanted stripe. The incorrect needles 19-21 are visible in Simulate as well. Ribber Classic 3-color flanking

IMG_2246

Heart-of-Pluto:

  1. Load up a 3-color image. I used the Mushroom sample, which is 3 colors and 36 pixels wide, L18-R18.
  2. Select Ribber:Heart of Pluto and 3 colors
  3. Tell it you're using needles L21-R21
  4. Bring needles L25-R25 into work.
  5. Cast on and knit in DBJ.
  6. Also do Simulate.

Expected: Both sets of flanking needles (19-21 that the software knows about, and 22-25 that it doesn't) should knit in white, once per row. Actual: Both sets of flanking needles knit once on some rows and twice in others. Always in white, so it's a lot less obvious on the knitted sample, but the edges are taller, you can count extra rows on the edges. Ribber-HoP 3-color flanking needles

IMG_2247