[FEAT] Keep the screen awake while knitting

AllYarnsAreBeautiful / ayab-desktop

The AYAB Software

http://ayab-knitting.com

GNU General Public License v3.0

56 stars 31 forks source link

[FEAT] Keep the screen awake while knitting #698

Open mathPi opened 3 weeks ago

mathPi commented 3 weeks ago

Issue I had:

While knitting a big piece, my computer automatically passed in screen save mode and thus my pattern was not updating anymore on the knitting machine

Proposed solution: I could just change the screen saver parameters to avoid that to append again but I think the best solution would be to lock the screen saver while knitting (like when watching a movie for instance).

This python package seems to do the job: wakepy

I just don´t know where to put it in Ayab code. If someone can help me, I can propose a PR.

mathPi commented 3 weeks ago

I tried a PR #699, what do you think about it ?

Adrienne200 commented 3 weeks ago

I asked about this in #258 , at the time it was decided not to do it. I still want this feature, so thanks for bringing it up again. As we have the Prefs panel, it may make more sense now.

mathPi commented 3 weeks ago

Ohh great, look at #699, I added the option in the preference screen.

jonathanperret commented 5 days ago

As I mentioned over in #699 I'm -1 on this being a preference — let's have it always enabled. Also, after talking to @dl1com on Discord, there seems to have been a misunderstanding over #258 — I think he's OK with preventing the computer from going to sleep, just not with trying to resume knitting after the computer has gone to sleep and back (@dl1com feel free to correct me if I've misrepresented your position).