search

AllYarnsAreBeautiful / ayab-firmware

Contains the Arduino Firmware for the AYAB Shield
GNU General Public License v3.0
23 stars 19 forks source link

After finishing the Knit operation, the FSM should enter state Init not state Ready #173

Closed t0mpr1c3 closed 1 week ago

X-sam commented 2 months ago

Is this related to AllYarnsAreBeautiful/ayab-desktop#577

jonathanperret commented 2 months ago

@X-sam I'd say they're not really related. https://github.com/AllYarnsAreBeautiful/ayab-desktop/issues/577 is about canceling, whereas this issue is about the normal end of knitting, and the linked PR (#174) changes the Knitter::stopKnitting method which is only called at the end of a complete knitting run.

In any case #174 does make the change requested here, I think this can be closed.