search

AllYarnsAreBeautiful / ayab-firmware

Contains the Arduino Firmware for the AYAB Shield
GNU General Public License v3.0
23 stars 19 forks source link

EOL refactor prototype #183

Open VIPQualityPost opened 9 months ago

VIPQualityPost commented 9 months ago

What do you think? The main idea is to remove the filtering from the encoder code, and instead only work with a new enum HallState which indicates if the hall sensor is inactive, north, or south. This successfully builds for both Uno and ESP32 environments. I still need to check if I associated the right transitions to the right carriages.

I have also snuck in a small change here to the ayab-esp32 board definition of PIO, changing partition to "default.csv" as the reference board I took it from was outdated.

github-actions[bot] commented 9 months ago

Test Results

0 tests  ±0   0 :white_check_mark: ±0   0s :stopwatch: ±0s 0 suites ±0   0 :zzz: ±0  0 files   ±0   0 :x: ±0 

Results for commit 18fedbef. ± Comparison against base commit aa76597f.

VIPQualityPost commented 9 months ago

Is @jpcornil-git going to create a PR for his new async encoder code? His is much better than mine, and achieves the same purpose, so we should think about that too. If not, I'm happy to also modify API docs and desktop app.

t0mpr1c3 commented 9 months ago

Is @jpcornil-git going to create a PR for his new async encoder code? His is much better than mine, and achieves the same purpose, so we should think about that too. If not, I'm happy to also modify API docs and desktop app.

Consensus was no in the meeting IIRC