AllYarnsAreBeautiful / ayab-firmware

Contains the Arduino Firmware for the AYAB Shield
GNU General Public License v3.0
23 stars 19 forks source link

Add optional stack overflow checking #189

Closed jonathanperret closed 3 months ago

jonathanperret commented 3 months ago

While working on getting the hardware test mode to work, I encountered some erratic behaviours (like the Arduino spontaneously resetting) that made me suspect memory corruption. As the Arduino UNO has only 2048 bytes of RAM, it is very easy to exhaust the available memory in a way that is not detected at compilation time, but results in the program stack (which grows down from the top of memory) overwriting the heap and static data areas.

So I added some code to try to detect such a situation: with the ENABLE_STACK_CANARY #define, a "stack canary" is enabled which will detect the stack growing past the top of the heap and enter a "panic" mode to show the problem occurring (by flashing a LED). The canary does consume a few bytes of RAM, so in theory it could itself be the proverbial needle that breaks the camel's back, but if these few bytes are the only margin of safety, a problem probably needs to be addressed.

Note that in this PR the canary is disabled by default (in platformio.ini), because it actual triggers in normal knitting use, illustrating that there is a problem that needs to be addressed. I have an upcoming PR that offers improvements on this front.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

This update introduces a stack canary mechanism to enhance memory safety by detecting stack buffer overflows. The platformio.ini file is modified to potentially enable this feature, while the main code in src/ayab/main.cpp integrates functions for setting up and checking the stack canary. Additionally, the README.md provides instructions for enabling this security feature. These changes aim to improve the robustness and security of the application, ensuring better protection against runtime vulnerabilities.

Changes

Files Change Summary
platformio.ini Added a build_flags entry for ENABLE_STACK_CANARY, currently commented out to suggest future enhancement.
src/ayab/main.cpp Introduced stack canary functions (stackCanarySetup() and stackCanaryCheck()) to detect buffer overflows; integrated them into setup() and loop().
README.md Added instructions for enabling stack overflow detection, guiding users on modifying the configuration and monitoring behavior.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Firmware
    participant StackCanary

    User->>Firmware: Modify platformio.ini to enable stack canary
    User->>Firmware: Build and upload firmware
    Firmware->>StackCanary: stackCanarySetup()
    StackCanary->>Firmware: Initialize canary
    Firmware->>Firmware: Execute main loop
    Firmware->>StackCanary: stackCanaryCheck()
    alt Canary value intact
        StackCanary-->>Firmware: Continue normal execution
    else Canary value altered
        StackCanary-->>Firmware: Trigger panic mode
        Firmware->>User: Indicate stack overflow via LED and serial output
    end

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
dl1com commented 3 months ago

Could your write some lines about the ENABLE_STACK_CANARY in the README.mde (basically the description of the PR)? So it's no "hidden feature"

jonathanperret commented 3 months ago

Could your write some lines about the ENABLE_STACK_CANARY in the README.mde (basically the description of the PR)? So it's no "hidden feature"

Sure thing. I added a section to README.md (https://github.com/AllYarnsAreBeautiful/ayab-firmware/blob/7b77503/README.md#enabling-stack-overflow-detection), let me know if that's what you had in mind.

Note that once #190 is fixed, this check could perhaps remain enabled all the time, to avoid stack overflow bugs creeping back in.