Open jonathanperret opened 1 month ago
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The goal is to test the AYAB firmware at a higher level by looking at the Arduino interactions instead of mocking parts of the firmware.
This is a test-only PR: it does not change any code in the built firmware. The few alterations made to files outside the
test
subdirectory are removing test-specific overrides so that more of the code can be tested.This involves creating a realistic model of a knitting machine's behavior, so that for example a test can simulate moving a carriage over a position sensor and the model will accurately simulate the encoder pulses and sensor values.
In this PR, the
KnittingMachine
class implements this model. Its own test suite (intest_knitting_machine.cpp
), unrelated to the AYAB firmware, consists of tests that can be reproduced on a real machine to confirm the model's accuracy.Still to do before review: