search

AllYarnsAreBeautiful / ayab-hardware

Contains the schematics and layouts for the AYAB Arduino shield
Creative Commons Attribution Share Alike 4.0 International
33 stars 15 forks source link

Add kicad and gerber versions of shield design #39

Open vthunder opened 3 months ago

dl1com commented 1 month ago

@VIPQualityPost would you mind to take a short view on this PR?

VIPQualityPost commented 1 month ago

The layout of directory does not make a ton of sense to me. We should try to re-sort it so that there is a single directory for all files related to the KiCad parts and a different one related to the Eagle parts (do we need to even keep these around @dl1com ? They are retained in version control, nobody is using Eagle anymore and these files are probably bitrotted anyway)

Schematic: The symbols in schematic have not really been 'updated' to KiCad symbols, which to me is fine, but I do think it's problematic that the manufacturing information is not included in the fields, we need to include a field for part vendor, part number at the minimum (to ID headers, ICs, etc). Ideally also a mouser or digikey part number.

Screenshot 2024-09-28 at 7 54 14 PM

PCB: It might be nice on silkscreen layer to indicate what connectors are for what models, it seems a common issue when assembling the board that users are confused and making incorrect choices, but the manual/build instruction also maybe could be a bit clearer.

There also was a comment from @jonathanperret this week in Discord about accidentally marring the board during assembly causing short from +15V to +5V, killing Arduino. I don't think it makes much sense to have a pour for +5V , especially on an outer layer, we might want to just fix this now so that in the future it's not problems for anyone (the action requested here being that the pour on top layer is changed to GND net instead of +5V, and that the pour clearance increased from 0.4mm to something larger, maybe 0.75mm.)

Overall looks great, thanks for the contributions!