AllYourBot / hostedgpt

An open version of ChatGPT you can host anywhere or run locally.
MIT License
344 stars 165 forks source link

Further improve PWA #298

Open krschacht opened 4 months ago

krschacht commented 4 months ago
krschacht commented 4 months ago

@jasonpaulso I had accidentally marked this PWA issue as complete but there are still some improvements. I just cleaned this up to it's up to date. If you feel so inclined :) the top two items on this list would be particularly impactful. Some of the others might be easy too.

jasonpaulso commented 4 months ago

Absolutely @krschacht I can work on the remaining items

jasonpaulso commented 3 months ago

@krschacht just letting you know that I'm still working on this. I think I've sorted a few points and a few others I'm noodling on.

krschacht commented 3 months ago

Thanks @jasonpaulso , you're awesome. And in case you didn't notice yet, a couple days ago, I slipped a new one to the very top of the list. As I've been using the mobile experience more, this might be the single biggest usability issue.

krschacht commented 2 months ago

@jasonpaulso I just noticed a couple new small visual issues that seemed to crop up. I don’t know if these were part of the latest PR but I don’t think we had these a couple months ago.

First, here is a screenshot:

image
  1. In the top left corner, as the assistants scroll beneath the sticky assistant there is a little gap where they are visible. We used to have a spacer element in this slot that existed solely to fill it so we don’t see these peeking through.
  2. At the bottom of the screen, the left sidebar has a dark gray background which no longer extends to the very bottom of the screen and, actually, I guess the main right column has a light gray background which also doesn’t extend. I know we added that extra space for the iOS menu handle but I was pretty sure that this extra space only pushed up the contents of the main column whereas now it’s actually pushing up the whole page.

These are small visual things, but I thought I’d mention while things are fresh b/c maybe you might immediately know what caused these.

jasonpaulso commented 2 months ago

I’d say it’s likely related to something I’ve done. I can sort it out on Monday!

On Jun 12, 2024, at 7:03 PM, Keith Schacht @.***> wrote:

@jasonpaulso https://github.com/jasonpaulso I just noticed a couple new small visual issues that seemed to crop up. I don’t know if these were part of the latest PR but I don’t think we had these a couple months ago.

First, here is a screenshot: image.png (view on web) https://github.com/AllYourBot/hostedgpt/assets/35061/6b6a58fd-2eea-466a-b2d8-6340fd0a4b52 In the top left corner, as the assistants scroll beneath the sticky assistant there is a little gap where they are visible. We used to have a spacer element in this slot that existed solely to fill it so we don’t see these peeking through. At the bottom of the screen, the left sidebar has a dark gray background which no longer extends to the very bottom of the screen and, actually, I guess the main right column has a light gray background which also doesn’t extend. I know we added that extra space for the iOS menu handle but I was pretty sure that this extra space only pushed up the contents of the main column whereas now it’s actually pushing up the whole page. These are small visual things, but I thought I’d mention while things are fresh b/c maybe you might immediately know what caused these.

— Reply to this email directly, view it on GitHub https://github.com/AllYourBot/hostedgpt/issues/298#issuecomment-2164035145, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACT5ZUSBP4XRC43YDPVFFHDZHDHVXAVCNFSM6AAAAABGVZWECCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGAZTKMJUGU. You are receiving this because you were mentioned.