Closed Rmpanga closed 1 month ago
The external_id makes sense. Thanks for adding this!
Can we remove the annotate gem, though? I am really trying to minimize external dependencies since every gem is one to keep updated over time. I also don’t the comment at the top of the model files. People can just open schema.rb or often a dev already has bin/rails dbconsole
open anyway \dt table;
or has bin/rails c
open and model.attributes
. I feel like most devs have fallen into some habit already since having a big comment at the top of models isn’t a standard pattern we’re all invariably falling back to one of these other methods which every project supports.
BTW, I have an overall thought about this direction, let me throw it back in our other thread: https://github.com/allyourbot/hostedgpt/discussions/345
rails dbconsole
Yes I can remove the annotate gem. I find it useful but if other don't that no problem.
I went ahead and cleaned this up so I could get it merged in.
Description of Changes
Change 1 Created a new column called
external_id
to the following modelsWhat does
external_id
represent?Change 2: The
external_id
column is unique only for assistant and conversation modelsChange 3: Added annotation gem
Testing done