AllYourBot / hostedgpt

An open version of ChatGPT you can host anywhere or run locally.
MIT License
304 stars 122 forks source link

Assistant model updates #367

Closed Rmpanga closed 1 month ago

Rmpanga commented 2 months ago

Description of Changes

Change 1 Created a new column called external_id to the following models

  1. Assistant
  2. Conversation
  3. Run
  4. Step

What does external_id represent?

Change 2: The external_id column is unique only for assistant and conversation models

Change 3: Added annotation gem

Testing done

krschacht commented 2 months ago

The external_id makes sense. Thanks for adding this!

Can we remove the annotate gem, though? I am really trying to minimize external dependencies since every gem is one to keep updated over time. I also don’t the comment at the top of the model files. People can just open schema.rb or often a dev already has bin/rails dbconsole open anyway \dt table; or has bin/rails c open and model.attributes. I feel like most devs have fallen into some habit already since having a big comment at the top of models isn’t a standard pattern we’re all invariably falling back to one of these other methods which every project supports.

krschacht commented 2 months ago

BTW, I have an overall thought about this direction, let me throw it back in our other thread: https://github.com/allyourbot/hostedgpt/discussions/345

Rmpanga commented 2 months ago

rails dbconsole

Yes I can remove the annotate gem. I find it useful but if other don't that no problem.

krschacht commented 1 month ago

I went ahead and cleaned this up so I could get it merged in.