AllanCameron / PDFR

An R package to extract text from pdf.
Other
37 stars 3 forks source link

Update documentation and refactor type checks using `{rlang}` functions #5

Closed elipousson closed 1 year ago

elipousson commented 1 year ago

This pull request exports the documentation and clears all of the errors and notes from devtools::check() per #4. There is still the outstanding warning I mentioned in the comments for that issue.

A few things to flag when you have a chance to review:

For what it is worth, I don't have any expectation that you'll dig back into this package if you've already put it to the side but I appreciate you considering a pull request to get the documentation into a more usable state!

AllanCameron commented 1 year ago

Happy to have you as a contributor Eli! Thank you. I like the suggestions. I think the multiple pdfpage bug will have to be handled at the C++ level.