Inconsistent notebook/editor versus vim opened in terminal

[jhwang7628]

Hi,

I greatly appreciate your work as solarized dark has been my go-to theme for almost a decade now. I mainly have three questions:

• It seems that the theme doesn't really work if I open vim inside a terminal (inside jupyterlab). See the first attached screenshot for example.
• To make it even more complicated, the current py file syntax coloring seems also different from my local computer running native terminal + vim. See the second attached screenshot for example.
• And finally, I do believe my local setup is more "faithful" to the original design of solarized palettes (third screenshot from https://raw.githubusercontent.com/altercation/solarized/master/img/screen-python-dark.png).

My question is, is it possible to make all of them (jupyter notebook in lab, jupyter editor in lab, and terminal + vim in lab) consistent with the original scheme? I am happy to contribute as this is super important to me but I don't know where to start. Thanks!

[jhwang7628]

Cross referencing the solarized color package I used for vim: https://github.com/altercation/vim-colors-solarized/issues/234

[AllanChain]

the theme doesn't really work if I open vim inside a terminal

There's something wrong with your vim config. Your vim uses the default theme when started in the terminal in JupyterLab. This extension doesn't touch your vim config so I'm afraid I won't be able to help you with this.

py file syntax coloring seems also different

I'll look into solarized themes in other editors and try to make the theme better.

From the screenshots you posted, the differences include

1. color of import: green vs red. I don't think it's possible to use different colors for import and other keywords in CodeMirror.
2. color of function definitions: red vs blue
3. color of numbers: magenta vs cyan. However, VS Code also uses magenta for numbers in solarized dark theme, so this should be ok.
4. color of built-in functions: green (not solarized) vs blue

[jhwang7628]

Thanks. Indeed you are right. I was using the default them in that screenshot, my bad. It was because that is what's closest to the solarized color I would get locally. This is what I get if I changed to the solarized theme in vim. My question: are you able to generate correct vim coloring when opening in terminal?

[AllanChain]

I'll look into solarized themes in other editors and try to make the theme better.

I don't think there's a "standard" for all the solarized themes, so I prefer to maintain the original design and just replace the non-solarized colors.

My question: are you able to generate correct vim coloring when opening in terminal?

No. Again this is a JupyterLab theme, not a Vim theme. Using a JupyterLab theme should never magically configure Vim.

As for the screenshot, I think you have misconfigured Vim. I'm using NeoVim and when I switch the solarized dark theme, it looks like this: