search

AllanWang / Frost-for-Facebook

An extensive and functional third party app for Facebook
https://allanwang.github.io/Frost-for-Facebook/
GNU General Public License v3.0
1.1k stars 85 forks source link

Share image externally #1478

Open wolph opened 5 years ago

wolph commented 5 years ago

Describe the feature

Instead of sharing a link to a post it would be very useful if you could directly share images. Within the Facebook app this is called share external and I use it often to share images from private groups on Google hangouts and other chat apps

AllanWang commented 5 years ago

You can share images directly from the image activity. If you can long press with an image popup, pressing the download icon will then allow you to share image. As sharing requires a local file, this workflow is required.

For other cases, I think it makes sense to keep the option of sharing links, since users may also want to share the post containing the image. You can elaborate if you have a different use case

wolph commented 5 years ago

Not sure if that's really the case @allanwang Chrome allows me to share an image immediately without downloading first so it should be possible.

AllanWang commented 5 years ago

Well you can both download and send the share request in one execution. I don't think it is necessary to add both download and share in one page, as that leads the user to believe that sharing does not also download it. I don't bother dealing with additional caches to avoid downloading something twice etc

wolph commented 5 years ago

And it wouldn't be an option to turn it around? Or make it configurable?

The download -> share feature clobbers my photo album quite a lot. And you can use the share feature to store a file.

AllanWang commented 5 years ago

I will consider adding better share options in the future. Turning it around doesn't make sense as users shouldn't be prompted to share images when they just want to download.

wolph commented 5 years ago

I understand the reasoning. I personally don't understand why people want to download images if it's not for sharing. But that's just me.

Thank you for the amazing app and quick response by the way.

On Mon, 8 Jul 2019, 06:15 Allan Wang, notifications@github.com wrote:

I will consider adding better share options in the future. Turning it around doesn't make sense as users shouldn't be prompted to share images when they just want to download.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AllanWang/Frost-for-Facebook/issues/1478?email_source=notifications&email_token=AACCB2ZWDM3FH4GYCFDLR43P6K5ONA5CNFSM4H6VEFO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZL5I4A#issuecomment-509072496, or mute the thread https://github.com/notifications/unsubscribe-auth/AACCB23NUCPC7YHCUMRIF7DP6K5ONANCNFSM4H6VEFOQ .