search

AllanWang / Frost-for-Facebook

An extensive and functional third party app for Facebook
https://allanwang.github.io/Frost-for-Facebook/
GNU General Public License v3.0
1.09k stars 85 forks source link

Blend top bar with theme #1605

Open alekksander opened 4 years ago

alekksander commented 4 years ago

please add possibility to have top bar integrate with the rest of the theme as it is in other android applications such as firefox, qksms ( https://github.com/moezbhatti/qksms/ ) or material files ( https://github.com/zhanghai/MaterialFiles ).

topbar

AllanWang commented 4 years ago

What does Frost look like? The status bar should already change based on the defined header color. Nothing in Frost is really to Material spec since I give users the option to pick any color combination, but the general look is similar.

AllanWang commented 4 years ago

To clarify, if you are talking about the appbar, you can change the header color in settings to match background color

alekksander commented 4 years ago

It adapts color partially, and remains slightly grey, like shadow on preffered color. Sorry, I'm unable to provide screenshot now.

AllanWang commented 4 years ago

I can update the status bar tint to match the header

alekksander commented 4 years ago

Would be great if that's what You are agreeing to have in Frost :)

AllanWang commented 4 years ago

After seeing the current guidelines (https://material.io/design/color/dark-theme.html), it appears that most themes do still use two shades. Themes also have colorPrimary and colorPrimaryDark. Light themes with white backgrounds seem to be an exception, so I may consider adding an option for disabling the shade or disabling it for white only