search

AllanWang / Frost-for-Facebook

An extensive and functional third party app for Facebook
https://allanwang.github.io/Frost-for-Facebook/
GNU General Public License v3.0
1.09k stars 85 forks source link

Links are not opened with overlays enabled #1934

Open sha-265 opened 1 year ago

sha-265 commented 1 year ago

Describe the bug Links are not opened with overlays enabled. The page keeps loading, when using overlays.

When overlays are disabled, same links are working fine.

To Reproduce Steps to reproduce the behavior:

  1. Enable overlays.
  2. Click on link that should be open an overlay.
  3. See if page is loaded.

Details (please provide at least the app version):

Logs/Screenshots:

image

Michael-C-GIT commented 1 year ago

I can confirm that overlays do not seem to be loading in 3.2.0.

However, it's a bit unclear to me what is considered an "overlay" in this app. For example, when I use search and select an autocompleted page, it still seems to use overlays even after disabling the behaviour setting.

BradB58 commented 1 year ago

I can also confirm this issue with overlays. I am using app version 3.2.0 on Android 11. I have to disable overlays or the app is nearly unusable for me. As mentioned, I also find that the search function still seems to be using overlays even when overlays are disabled.

I am so disappointed that this app is breaking because there are no viable alternatives. All of the FB wrapper apps seem to have been abandoned and are broken in some way or another. Normally, in this situation I would just use a mobile web app with Brave browser, but I can't even do that, because the Facebook mobile web app has a deal breaker issue that when you scroll up the news feed the Facebook top tool bar scrolls away too so that you can't navigate anywhere without scrolling all the way back or refreshing the page!

I sure hope someone with the right skills will take an interest in maintaining this app. It is the best Facebook wrapper I have ever used and I'm sorry to see it go. :(

sorlib commented 1 year ago

Same problem and ways around link opening failure, but not a fix.

vinibali commented 1 year ago

Turning off the overlays is a somewhat working solution for now

AllanWang commented 1 year ago

I can't guarantee updates, but it does affect me too so I will be taking a look at my off time in June. I'm still not interested in patching the current state of Frost, but rather make something new (with similar UX) using firefox's browser. If I can achieve that, this will be fixed, and it will also be more easily updatable, but it's a big task since all the web functionality will have to be updated.

vinibali commented 1 year ago

This time turning off the overlays doesn't seem to work anymore. Many times, shared posts are not open up. The original post might be openable, however the shared one remain black. It works fine with m.facebook.com in the browser.