search

AllegianceZone / Allegiance

Allegiance is a multiplayer online game providing a mix of real-time strategy and player piloted space combat gameplay.
http://allegiancezone.com
MIT License
10 stars 7 forks source link

Usage of ZVersionInfo().... is brittle. #53

Open Astn opened 7 years ago

Astn commented 7 years ago

Stuff like this needs to be handled in a way that is not so brittle.

WinTrek.cpp::TrekWindowImpl::ShowMainMenu ln # 4145 

            ZString dVer, dYY, dMM, dDD;
            dVer = ZVersionInfo().GetStringValue("FileVersion").Right(6);
            dR = ZVersionInfo().GetProductVersionString().Middle(3,1); // TODO: Imago good till R10
            dDD = dVer.Right(2);
            dMM = dVer.Middle(2,2);
            dYY = dVer.Middle(0,2);