Open kwalcock opened 1 year ago
@Allegra-Cohen, in case you are only notified when directly addressed.
@kwalcock you're right! I think I threw this function together quite quickly so pretty sure I didn't have a reason to skip abs other than making a mistake. Thanks!
There may be an absolute value or two missing in https://github.com/Allegra-Cohen/grid/blob/8670a1ed8255a770d351efb5885f445d816ddc78/habitus_ui_interface-main/backend/mathematician.py#L287-L294
If a centroid and last_centroid are [0, 0, 0] and [10, 10, 10], then centroid - last_centroid is [-10, -10, -10] with a mean of -10, which is certainly less than 0.00001.
If a centroid and last_centroid are [0, 0, 0] and [10, 0, -10], then centroid - last_centroid is [-10, 0, 10] with a mean of 0, which is also less than 0.00001.
It doesn't seem like that fits the definition of convergence.
The code may have to be
for the first issue or even
to take care of them both.