Allen-B1 / news

RSS feed reader
GNU General Public License v3.0
11 stars 6 forks source link

News reference from commit 1d69dbf #12

Closed mirkobrombin closed 7 years ago

mirkobrombin commented 7 years ago

From commit 1d69dbf you reference to "News": .. News.add_page(null); .. which is not declared and return errors on build:

news.vala:105.21-105.24: error: The nameNews' does not exist in the context of main' root.pack_start(News.create_toolbar(window), false, false, 0); ^^^^ news.vala:111.5-111.8: error: The nameNews' does not exist in the context of main' News.add_page(null); ^^^^ Compilation failed: 2 error(s), 0 warning(s)

Allen-B1 commented 7 years ago

Have you run

cmake /usr ./

again and not just make? Try that

mirkobrombin commented 7 years ago

Yes

Allen-B1 commented 7 years ago

It works now (at least for me). Maybe you're not on the newest version? (git pull)

Allen-B1 commented 7 years ago

I forgot to add widgets.vala oops. Does it work now?

mirkobrombin commented 7 years ago

I think yes. Previously I had to use wake for the build because of a problem with "cmake /usr ./" `CMake Error at CMakeLists.txt:24 (find_package): By not providing "FindVala.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Vala", but CMake did not find one.

Could not find a package configuration file provided by "Vala" with any of the following names:

ValaConfig.cmake
vala-config.cmake

Add the installation prefix of "Vala" to CMAKE_PREFIX_PATH or set "Vala_DIR" to a directory containing one of the above files. If "Vala" provides a separate development package or SDK, be sure it has been installed. `

Allen-B1 commented 7 years ago

Ok so it works now right?

mirkobrombin commented 7 years ago

can't build see my latest comment 😂

Allen-B1 commented 7 years ago

Oh that! Are you on Elementary OS? If so, try

sudo apt install elementary-sdk
mirkobrombin commented 7 years ago

yes Loki 0.4.1

Allen-B1 commented 7 years ago

Did installing the elementary-sdk work?

mirkobrombin commented 7 years ago

I will try after dinner

Allen-B1 commented 7 years ago

Ok, when you try, if it works, close this issue. Thanks for reporting this to me!

mirkobrombin commented 7 years ago

It's working!