search

AllenCell / allencell-segmenter-ml

Napari plugin for ml segmentation
Other
1 stars 0 forks source link

Curation record list changed directly in model state #295

Open saeliddp opened 5 months ago

saeliddp commented 5 months ago

From review w/ brian and chris:

Could store state directly in curation record list instead of storing it as fields and then saving fields when next is hit

saeliddp commented 5 months ago

Some thoughts I had recently related to further curation refactoring:

  1. it feels weird that we have one model but two views; is it possible to have two models, one for each view (maybe even two services?). This one isn't super critical I think
  2. CurationImageLoader violates the principles behind the initial refactor because it runs async code and curationModel has a reference to it. This makes testing tricky, which is what we want to avoid. I'm wondering if it would be possible to deprecate the image loader and instead use the model/service pattern for all of our needs here.