AllenCell / cvapipe

Cell Variance Analysis Pipeline
Other
2 stars 0 forks source link

feature/first-pass-cells-along-pcs #12

Closed donovanr closed 4 years ago

donovanr commented 4 years ago

Pull request recommendations:

Thanks for contributing!

donovanr commented 4 years ago

getting flake8 errors that black isn't fixing -- should setup.cfg be updated so that black and flake8 agree on formatting?

cvapipe/steps/pca_path_cells/pca_path_cells.py:34:89: E501 line too long (125 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:54:89: E501 line too long (89 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:72:89: E501 line too long (140 > 88 characters)
cvapipe/steps/pca_path_cells/pca_path_cells.py:92:89: E501 line too long (92 > 88 characters)
cvapipe/steps/pca_path_cells/utils.py:27:1: W293 blank line contains whitespace
cvapipe/steps/pca_path_cells/utils.py:35:86: E231 missing whitespace after ','
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:34:89: E501 line too long (125 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:54:89: E501 line too long (89 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:72:89: E501 line too long (140 > 88 characters)
cvapipe/steps/pca_path_cells/.ipynb_checkpoints/pca_path_cells-checkpoint.py:92:89: E501 line too long (92 > 88 characters)
evamaxfield commented 4 years ago

Potentially also add a test for this?

donovanr commented 4 years ago

added a test for correct output size. does not test correctness of distance algorthim