AllenCell / napari-allencell-segmenter

A plugin that enables image segmentation provided by Allen Institute for Cell Science
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Bugfix/dimension order czi fix #118

Closed yrkim98 closed 3 years ago

yrkim98 commented 3 years ago

Fix for https://github.com/AllenCell/napari-allencell-segmenter/issues/116 and https://github.com/AllenCell/napari-allencell-segmenter/issues/117

yrkim98 commented 3 years ago

stuck on mocking and macking one test pass

yrkim98 commented 3 years ago

This is complete- tests should pass once aics-segmentation unpins the <4 aicsimageio requirement and pushes out a new version.

codecov[bot] commented 3 years ago

Codecov Report

Merging #118 (7d5e119) into main (da0d4a0) will increase coverage by 0.03%. The diff coverage is 95.65%.

:exclamation: Current head 7d5e119 differs from pull request most recent head 6db6ae2. Consider uploading reports for the commit 6db6ae2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   84.63%   84.66%   +0.03%     
==========================================
  Files          34       34              
  Lines        1425     1435      +10     
==========================================
+ Hits         1206     1215       +9     
- Misses        219      220       +1     
Impacted Files Coverage Δ
napari_allencell_segmenter/core/layer_reader.py 87.69% <93.75%> (-0.45%) :arrow_down:
...ri_allencell_segmenter/view/workflow_steps_view.py 91.61% <100.00%> (+0.10%) :arrow_up:
...allencell_segmenter/widgets/workflow_thumbnails.py 83.51% <100.00%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da0d4a0...6db6ae2. Read the comment docs.