AllenCell / napari-allencell-segmenter

A plugin that enables image segmentation provided by Allen Institute for Cell Science
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Fix/use qtpy instead of PyQt5 #130

Closed schoinh closed 2 years ago

schoinh commented 2 years ago

Closes #129

Because we were using PyQt5 directly instead of using qtpy (abstraction layer), sometimes the plugin wasn't able to open depending on the user's environment. More info: https://napari.org/plugins/stable/best_practices.html#don-t-include-pyside2-or-pyqt5-in-your-plugin-s-dependencies

Changes:

Pull request recommendations:

Thanks for contributing!

codecov[bot] commented 2 years ago

Codecov Report

Merging #130 (2d850ec) into main (1411ce2) will increase coverage by 0.03%. The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   84.66%   84.70%   +0.03%     
==========================================
  Files          34       34              
  Lines        1435     1432       -3     
==========================================
- Hits         1215     1213       -2     
+ Misses        220      219       -1     
Impacted Files Coverage Δ
...egmenter/controller/batch_processing_controller.py 65.06% <33.33%> (-0.38%) :arrow_down:
napari_allencell_segmenter/_dock_widget.py 45.45% <100.00%> (ø)
napari_allencell_segmenter/core/view.py 89.28% <100.00%> (ø)
napari_allencell_segmenter/util/ui_utils.py 100.00% <100.00%> (ø)
napari_allencell_segmenter/view/_main_template.py 100.00% <100.00%> (ø)
..._allencell_segmenter/view/batch_processing_view.py 98.75% <100.00%> (+2.27%) :arrow_up:
...i_allencell_segmenter/view/workflow_select_view.py 96.87% <100.00%> (ø)
...ri_allencell_segmenter/view/workflow_steps_view.py 91.61% <100.00%> (ø)
...lencell_segmenter/widgets/batch_complete_dialog.py 23.33% <100.00%> (ø)
napari_allencell_segmenter/widgets/file_input.py 77.50% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1411ce2...2d850ec. Read the comment docs.