Closed schoinh closed 2 years ago
Merging #130 (2d850ec) into main (1411ce2) will increase coverage by
0.03%
. The diff coverage is93.54%
.
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 84.66% 84.70% +0.03%
==========================================
Files 34 34
Lines 1435 1432 -3
==========================================
- Hits 1215 1213 -2
+ Misses 220 219 -1
Impacted Files | Coverage Δ | |
---|---|---|
...egmenter/controller/batch_processing_controller.py | 65.06% <33.33%> (-0.38%) |
:arrow_down: |
napari_allencell_segmenter/_dock_widget.py | 45.45% <100.00%> (ø) |
|
napari_allencell_segmenter/core/view.py | 89.28% <100.00%> (ø) |
|
napari_allencell_segmenter/util/ui_utils.py | 100.00% <100.00%> (ø) |
|
napari_allencell_segmenter/view/_main_template.py | 100.00% <100.00%> (ø) |
|
..._allencell_segmenter/view/batch_processing_view.py | 98.75% <100.00%> (+2.27%) |
:arrow_up: |
...i_allencell_segmenter/view/workflow_select_view.py | 96.87% <100.00%> (ø) |
|
...ri_allencell_segmenter/view/workflow_steps_view.py | 91.61% <100.00%> (ø) |
|
...lencell_segmenter/widgets/batch_complete_dialog.py | 23.33% <100.00%> (ø) |
|
napari_allencell_segmenter/widgets/file_input.py | 77.50% <100.00%> (ø) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1411ce2...2d850ec. Read the comment docs.
Closes #129
Because we were using PyQt5 directly instead of using qtpy (abstraction layer), sometimes the plugin wasn't able to open depending on the user's environment. More info: https://napari.org/plugins/stable/best_practices.html#don-t-include-pyside2-or-pyqt5-in-your-plugin-s-dependencies
Changes:
PyQt5
withqtpy
Signal
instead ofqtpySignal
fromQtCore
(necessary after the above change)exec_()
instead ofexec()
forQDialog
widgets (per napari's advice, and it matches the Qt docs. Not positive this affects the user's ability to open the plugin, but seems like a good thing to do)Pull request recommendations:
Thanks for contributing!