search

AllenCell / napari-allencell-segmenter

A plugin that enables image segmentation provided by Allen Institute for Cell Science
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

bugfix/mac_dropdown_box_fix #137

Closed yrkim98 closed 2 years ago

yrkim98 commented 2 years ago

Fixing weird behavior with dropdown boxes on macos. https://github.com/AllenCell/napari-allencell-segmenter/issues/135 related to this

The property maxVisibleItems is ignored for non-editable comboboxes in styles that returns true for QStyle::SH_ComboBox_Popup

codecov[bot] commented 2 years ago

Codecov Report

Merging #137 (0c8dcdf) into main (fa1171f) will increase coverage by 0.02%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   75.50%   75.53%   +0.02%     
==========================================
  Files          35       35              
  Lines        1915     1921       +6     
==========================================
+ Hits         1446     1451       +5     
- Misses        469      470       +1
Impacted Files Coverage Δ
..._allencell_segmenter/widgets/param_sweep_widget.py 13.12% <0.00%> (-0.06%) :arrow_down:
napari_allencell_segmenter/util/ui_utils.py 100.00% <100.00%> (ø)
...i_allencell_segmenter/view/workflow_select_view.py 97.00% <100.00%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa1171f...0c8dcdf. Read the comment docs.