search

AllenCell / napari-allencell-segmenter

A plugin that enables image segmentation provided by Allen Institute for Cell Science
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Explicit dependency on PyQt5 instead of qtpy #149

Closed goanpeca closed 1 year ago

goanpeca commented 1 year ago

Hello team!

The plugin documentation for napari has a set of best practices for developers, which includes a clause recommending not to depend directly on PyQt5 or PySide2 to allow end-users to choose their bindings freely. More details here.

Files using PyQt5 instead of qtpy -> https://github.com/AllenCell/napari-allencell-segmenter/search?q=PyQt5

Is there a reason you need PyQt5 explicitly? If not, could you please make the fixes for the next release :) ?

Thanks!