Open sebi06 opened 3 years ago
Hi @sebi06, you are correct. When I first implemented this we really weren't supporting mosaic files and were working with subblocks that spanned a scene and thus the current naming is a little odd. I've started working on a 3.0 version and will address changes in there. Once I have the API in a PR I will add you as a reviewer if you don't mind. I appreciate your pointing this out.
@heeler
I would rename:
mosaic_scene_bounding_boxes(index=SceneID)
-> get_all_mosaic_tile_bounding_boxes
scene_bounding_box
-> get_single_tile_bounding_info
scene_height_by_width
-> get_single_tile_height_by_width
All functions start with verb all props start with noun or static value:
get_image_data
or is_supported_image
data
or current_scene
Hi,
i used the following function over the last days and got a bit confused by the naming for the following functions
mosaic_scene_bounding_boxes(index=SceneID)
scene_bounding_box(index=SceneID)
scene_height_by_width(index=SceneID)
1st yields in a List with tuples for every tile of a specific scene = SceneID
2nd yields in a tuple for the first tile of a specific scene = SceneID with (xmin, ymin, width-of-tiles, height-of-tiles)
So why is the function called scene_bounding_box, because it does not return the BBox of the specific scene. Or did I misunderstood something here.
I tested this on a CZI file with 4 different scenes (different size and shape), where a single tile is always 640x640. The output is below. Or do I misinterpret the naming of those function. To me it looks like the term tile (many tile make up a scence)) is mixed up with the term scene (a scene has many tiles) a bit, isn't it?
Cheers, Sebi