Closed toloudis closed 2 years ago
Merging #98 (19a9974) into main (3dcc155) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 3 3
Lines 148 148
=======================================
Hits 146 146
Misses 2 2
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3dcc155...19a9974. Read the comment docs.
I was planning on doing a patch release of aicsimageio
today to release some updates to the XSLT. Should we get these changes incorporated for that release too?
I was planning on doing a patch release of
aicsimageio
today to release some updates to the XSLT. Should we get these changes incorporated for that release too?
Technically its a different lib so no real need to. Unless you simply wanted to update the minimum version pin.
I was planning on doing a patch release of
aicsimageio
today to release some updates to the XSLT. Should we get these changes incorporated for that release too?Technically its a different lib so no real need to. Unless you simply wanted to update the minimum version pin.
That's what I was thinking, but if that's not necessary that's fine.
@heeler I'm not sure I actually updated Eigen - it was an update that broke things. I pinned it according to the version that the libCZI devs recommended for me. And that dependency is inside the cmake files for libCZI, not in any cmake files that we control.
As for c++17 or 20, I'm all for it if it doesn't break anything in the dependencies. Kinda neutral on submodule vs cmake fetchcontent. submodule isn't exactly broken here but I like the newer cmake stuff too.
I update libCZI to fix a build issue. I also simplified the build rules here a bit. Related to https://github.com/zeiss-microscopy/libCZI/issues/60 for reference.