Closed psobolewskiPhD closed 2 years ago
Merging #60 (b7e8e90) into main (a7aad09) will increase coverage by
0.94%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 87.93% 88.88% +0.94%
==========================================
Files 4 3 -1
Lines 199 189 -10
==========================================
- Hits 175 168 -7
+ Misses 24 21 -3
Impacted Files | Coverage Δ | |
---|---|---|
napari_aicsimageio/core.py | 86.15% <100.00%> (ø) |
|
napari_aicsimageio/__init__.py |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I assume lint is fixed due to the other PR. Merging! Thanks!
This is a fix for: https://github.com/AllenCellModeling/napari-aicsimageio/issues/54 (see also: https://forum.image.sc/t/napari-napari-aicsimageio-faild-to-open-ome-tiff/68942/2?u=sebi06) Basically, when setting the scale metadata for napari, the original
img
was used, even if a singleton was squeezed. If the singleton happened to have a valid scale value, this was passed to napari, even though the dimension wasn't. The fix here checks the physicaldims
of the actual squeezed xarraydata
for scale data, so if a dim was squeezed, but had valid scale, it will be ignored.Pull request recommendations: