Open psobolewskiPhD opened 1 year ago
Base: 87.68% // Head: 87.29% // Decreases project coverage by -0.39%
:warning:
Coverage data is based on head (
be80320
) compared to base (3898b66
). Patch coverage: 83.33% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
To clarify. This PR should go in after the other merges correct? They are sort of tied together? Or is this a bug that currently exists?
This is just a fix for the bug/issue with the two-widget solution to multiscene files. Multiscene files open 2 widgets, with the scene selector needing values from the Scene Management widget. If that one is closed and a scene is selected from the selector widget, then the error is emitted.
It has nothing to do with the new settings widget. I guess I can see how it can be confusing...
Edit: note: I'm not sure this is the best or most pythonic fix. It's just a fix 😃
This PR aims to fix https://github.com/AllenCellModeling/napari-aicsimageio/issues/66 When a multi-scene file is loaded, two widgets are created. One has two checkboxes, the other has the scenes to load. The status of the first widget (the checkboxes) is checked when the scenes are to be loaded. As a result, if that widget is closed an error is raised.
In this PR, the first widget instead sets global variables, so it need not be open. If the settings are applied, then the widget can be closed and scenes can be loaded. (this permits more vertical space for scene selection, particularly on smaller screens—like mine!) Additionally, the previous values are persisted thanks to magicgui.