AllenCellModeling / napari-aicsimageio

Multiple file format reading directly into napari using pure Python
GNU General Public License v3.0
33 stars 10 forks source link

Documentation/Clarify-bioformats-requires-java-and-mvn #72

Closed psobolewskiPhD closed 1 year ago

psobolewskiPhD commented 1 year ago

This PR adds updates the README regarding the bioformats reader requiring java and mvn. Then in installation section, it also strongly suggests using conda-forge to install bioformats_jar.

See discussion here: https://github.com/AllenCellModeling/napari-aicsimageio/issues/46#issuecomment-1462895156

This should resolve that issue—I'm not sure how better to address it anyways.

Pull request recommendations:

Thanks for contributing!

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.88 :tada:

Comparison is base (2e8cdb7) 87.55% compared to head (4a34b65) 88.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================== + Coverage 87.55% 88.44% +0.88% ========================================== Files 4 3 -1 Lines 209 199 -10 ========================================== - Hits 183 176 -7 + Misses 26 23 -3 ``` [see 1 file with indirect coverage changes](https://codecov.io/gh/AllenCellModeling/napari-aicsimageio/pull/72/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AllenCellModeling) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AllenCellModeling). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AllenCellModeling)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

evamaxfield commented 1 year ago

Looks good to me! Thanks for all your work recently ❤️