search

AllenCellModeling / pytorch_fnet

Three dimensional cross-modal image inference
Other
151 stars 61 forks source link

Update pytorch #111

Closed counkomol closed 5 years ago

counkomol commented 5 years ago

This PR updates the package to a latest version of PyTorch (1.0). Also, the test setup for the command-line tests were updated/improved.

counkomol commented 5 years ago

All looks good. I would personally go back and remove all the os.path stuff in favour of pathlib.Path. Having the mixed libraries is meh to me.

Yes I agree, but to limit the scope of the PR, I chose to add new code using pathlib but keep the older code the same.

donovanr commented 5 years ago

The new version ran fine for me. Looks good enough to merge.