search

AllenDowney / ThinkComplexity2

Book and code for Think Complexity, 2nd edition
https://allendowney.github.io/ThinkComplexity2/
729 stars 658 forks source link

PROD: captions with code in them are broken #44

Open AllenDowney opened 6 years ago

AllenDowney commented 6 years ago

It looks like when I have a code snippet in a caption, the typesetting of the caption gets messed up. There's an example on page 119.

Same issue comes up in the footnote on page 124.

Is the DocBook I am generating correct, and getting rendered wrong, or is there something wrong with it?

kristenORM commented 6 years ago

It looks like the tags don't enclose the text they are supposed to (though I'm not sure why your DocBook is doing this). Take this example from Figure 2-4:

<literal` remap="verb" moreinfo="none">n=10 and <literal remap="verb" moreinfo="none"/></literal>p=0.3

I'm getting the copyedit file ready this morning, and will correct these as follows: <literal remap="verb" moreinfo="none">n=10</literal> and <literal remap="verb" moreinfo="none">p=0.3</literal>

AllenDowney commented 6 years ago

Ok, thanks. I will look into fixing this in my translator, but since there are not very many instances, it might be easier to fix them by hand.

kristenORM commented 6 years ago

Yeah, I have already fixed the figure captions by hand in Atlas (we've split the book file into individual chapter XML docs). Going to make a pass through the PDF to see if there are any others like the footnote you mentioned, but if I miss them, we can certainly fix by hand later.

AllenDowney commented 6 years ago

Sounds good. We can catch them in QC if you want to hold off.

On Thu, Jun 7, 2018 at 9:39 AM, Kristen Brown notifications@github.com wrote:

Yeah, I have already fixed the figure captions by hand in Atlas (we've split the book file into individual chapter XML docs). Going to make a pass through the PDF to see if there are any others like the footnote you mentioned, but if I miss them, we can certainly fix by hand later.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkComplexity2/issues/44#issuecomment-395423621, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy37flcrS9Fzlf3Hj1-_1eFDcFYbJmMks5t6S0SgaJpZM4UTpBl .