search

AllenDowney / ThinkDSP

Think DSP: Digital Signal Processing in Python, by Allen B. Downey.
https://allendowney.github.io/ThinkDSP/
3.97k stars 3.23k forks source link

Update chap02 #32

Closed struck89 closed 7 years ago

struck89 commented 7 years ago

The first line edited is self explanatory, that is a typo. If we create a sawtooth signal, we should say "sawtooth" instead of "triangle"

The second edit is needed, since the spectrum that we are modifying is from line 440, which is before creating the new sawtooth signal. I discovered it by making changes to duration and framerate of the sawtooth signal, and when playing the two comparative audios (with just different phases) the lenghts of the audios were completely different.

AllenDowney commented 7 years ago

Thank you!

struck89 commented 7 years ago

Thanks to you for your letting me think dsp ;)

JaejinCho commented 2 years ago

@AllenDowney Hello, thanks for sharing the great material! I was curious why two different approaches in exercise 5 in chap02soln resulted in different-looking waves. (Is this somehow related to phase?)

AllenDowney commented 2 years ago

Yes, they have the same amplitude at every frequency, but different phases.

If you are interested, I gave a talk about this exercise: https://www.dsprelated.com/showarticle/1419.php

On Fri, Sep 2, 2022, at 11:20 AM, JaejinCho wrote:

@AllenDowney https://github.com/AllenDowney Hello, thanks for sharing the great material! I was curious why two different approaches in exercise 5 in chap02soln resulted in different-looking waves. (Is this somehow related to phase?)

— Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkDSP/pull/32#issuecomment-1235626914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOLP3NFEA63LN4OMHLUPBLV4ILNVANCNFSM4DLRAGFQ. You are receiving this because you were mentioned.Message ID: @.***>

JaejinCho commented 2 years ago

Thank you @AllenDowney for the great pointer. I understood better after watching the video!