AllenDowney / ThinkDSP

Think DSP: Digital Signal Processing in Python, by Allen B. Downey.
https://allendowney.github.io/ThinkDSP/
3.93k stars 3.2k forks source link

Installation of thinkdsp #90

Open WuodOdhis opened 1 year ago

WuodOdhis commented 1 year ago

I am writing to express my disappointment and frustration with trying to install thinkdsp on my system. I have followed the instructions on the GitHub page, but I am still unable to get thinkdsp working. I have tried troubleshooting the issue on my own, but I am unable to resolve it.

I am very disappointed in the difficulty I have had trying to install thinkdsp, and I am asking for your help in resolving this issue. I would appreciate if someone from your team could provide assistance or offer guidance on how to successfully install thinkdsp.

Thank you for your attention to this matter. I look forward to hearing from you and receiving help with this issue.

AllenDowney commented 1 year ago

I'm sorry to hear that this has been frustrating. Are you following the instructions here?

https://allendowney.github.io/ThinkDSP/

If so, what have you tried and what went wrong?

Also, please consider running the notebooks on Colab (see the links on the page linked above). That way you don't have to install anything.

WuodOdhis commented 1 year ago

I downloaded the module thinkx because thinkdsp was unavailable. After getting it into my pc I am still unable to import libraries from thinkdsp.

On Mon, Dec 12, 2022 at 6:40 PM Allen Downey @.***> wrote:

I'm sorry to hear that this has been frustrating. Are you following the instructions here?

https://allendowney.github.io/ThinkDSP/

If so, what have you tried and what went wrong?

Also, please consider running the notebooks on Colab (see the links on the page linked above). That way you don't have to install anything.

— Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkDSP/issues/90#issuecomment-1346737874, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4WNUZ3XNSH42KGOHHFV4ATWM5BQFANCNFSM6AAAAAAS4CMBFY . You are receiving this because you authored the thread.Message ID: @.***>

WuodOdhis commented 1 year ago

Thank you sir for responding.

On Tue, Dec 13, 2022 at 6:55 PM Newton Sila @.***> wrote:

I downloaded the module thinkx because thinkdsp was unavailable. After getting it into my pc I am still unable to import libraries from thinkdsp.

On Mon, Dec 12, 2022 at 6:40 PM Allen Downey @.***> wrote:

I'm sorry to hear that this has been frustrating. Are you following the instructions here?

https://allendowney.github.io/ThinkDSP/

If so, what have you tried and what went wrong?

Also, please consider running the notebooks on Colab (see the links on the page linked above). That way you don't have to install anything.

— Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkDSP/issues/90#issuecomment-1346737874, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4WNUZ3XNSH42KGOHHFV4ATWM5BQFANCNFSM6AAAAAAS4CMBFY . You are receiving this because you authored the thread.Message ID: @.***>

AllenDowney commented 1 year ago

I understand. A key thing to understand is that thinkdsp.py is not a package you have to install; it is just a module -- that is, a file that contain Python code.

So you have to download it and make sure it is in a place where Python finds it. The easiest way to do that is to run the notebook and let it download thinkdsp.py, which it will do if it does not find the file already.

Which notebook are you running and where does it fail?

WuodOdhis commented 1 year ago

I'm using jupyter notebooks sir. I searched for the module and I was offered thinkx since thinkdsp.py doesn't exist independently. I saw it downloaded till I tried using it I my notebooks but still disappointed. Which procedure do you prefer sir?

On Tue, Dec 13, 2022 at 7:02 PM Allen Downey @.***> wrote:

I understand. A key thing to understand is that thinkdsp.py is not a package you have to install; it is just a module -- that is, a file that contain Python code.

So you have to download it and make sure it is in a place where Python finds it. The easiest way to do that is to run the notebook and let it download thinkdsp.py, which it will do if it does not find the file already.

Which notebook are you running and where does it fail?

— Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkDSP/issues/90#issuecomment-1348888752, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4WNUZYGDB24P5WDRHNUHC3WNCM2PANCNFSM6AAAAAAS4CMBFY . You are receiving this because you authored the thread.Message ID: @.***>

AllenDowney commented 1 year ago

Don't install thinkx.

When you run the notebook, it should download and then import thinkdsp.py.

Does that work? If not, what happens?

karelkedl commented 1 year ago

I had similar issues with "installing" this module. But I donť use jupyter notebooks. I installed it with pip install thinkx, but but thinkdsp won't import due to: ImportError: cannot import name 'gcd' from 'fractions'. I found out that fractions.gcd(a, b) has been moved to math.gcd(a, b) in Python 3.9 in this link. So i replaced fractions on line 24 with from math import gcd. And it is running. I still got warning about Wave.make_audio() but it is not an issue form me. Thank you for this module and for the book!