search

AllenDowney / ThinkStats2

Text and supporting code for Think Stats, 2nd Edition
http://allendowney.github.io/ThinkStats2/
GNU General Public License v3.0
4.01k stars 11.23k forks source link

Chapter 13 Solutions def ResampleDivorceCurve #185

Closed resonates7 closed 2 years ago

resonates7 commented 3 years ago

The solution for chapter 13 def ResampleDivorceCurve doesn't work.

It gives the error 'PlotDivorceCurveByDecade' is not defined. I don't see that defined anywhere in the notebook either.

AllenDowney commented 3 years ago

Thanks for letting me know. I will check this out as soon as I can.

resonates7 commented 3 years ago

I wouldn’t have raised an issue for this alone, but some aspects of this code will be deprecated. I changed the first bit of the notebook from suppressing future warnings to suppress deprecation warnings.

I tried to fix it myself, but it seems it’s imbedded deeply in the thinkstats code.

From: Allen Downey @.> Sent: Monday, July 19, 2021 5:36 PM To: AllenDowney/ThinkStats2 @.> Cc: resonates7 @.>; Author @.> Subject: Re: [AllenDowney/ThinkStats2] Chapter 13 Solutions def ResampleDivorceCurve (#185)

Thanks for letting me know. I will check this out as soon as I can.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkStats2/issues/185#issuecomment-882877838 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AL3TESO5535DISNHUFSSM63TYSLFXANCNFSM5AUP57MQ . https://github.com/notifications/beacon/AL3TESP4VCAHIWORUSNKOMTTYSLFXA5CNFSM5AUP57M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGSP2LDQ.gif

AllenDowney commented 2 years ago

This should work as of https://github.com/AllenDowney/ThinkStats2/commit/17edd83e944c607a49cc52a9d023a494ce3c2bfd