Closed Etrama closed 1 month ago
Thanks for bringing this to my attention, and thanks for the offer to make a PR, but I'll ask you to hold off.
First, a lot of the code in this repo gets generated from other code, so you don't want to modify the ones that get generated.
Second, I am unsure whether I will future-proof this code or not -- I might just pin it to Pandas < 3.0.
Thinking...
Food for thought- Cons:
Pros:
I'll leave the final decision to you.
Ok, I have made these changes in the notebooks, solutions, and text.
Thank you!
To make sure the code is future proof (pandas 3 proof), all the pandas operations that mention"inplace=True" need to be updated. At the time I checked, this was 53 results in 20 files:![image](https://github.com/AllenDowney/ThinkStats2/assets/22076465/b1d27388-9ecd-4244-b28e-cdb3217de46d)
No promises, but I might make a pull request that fixes this.
If you need more evidence: stackoverflow post.