search

AllenDowney / ThinkStats2

Text and supporting code for Think Stats, 2nd Edition
http://allendowney.github.io/ThinkStats2/
GNU General Public License v3.0
4.03k stars 11.31k forks source link

#76 Knocking out low-hanging py2/py3 compatibility with futurize fix-ups #77

Closed gbremer closed 7 years ago

gbremer commented 7 years ago

Fix-ups from futurize -- mainly print and division compatibility fixes. Tests run and pass with Py27 and Py36.

The notebooks have not been checked and ported yet.

AllenDowney commented 7 years ago

Thanks very much for this! It looks like there are a couple of actual compatibility issues here that I would like to fix, but the majority of what futurize generates is not necessary, and makes the code less clean.

I will apply the changes that make a difference, though.

gbremer commented 7 years ago

I'm happy to clean those things up and send along a review -- just give me nudge to where you want things to go. I still need to go through the IPython noteooks as well so I expect to create at least one more pull request.

AllenDowney commented 7 years ago

Please take a look at 0571a26ed4b003c13adb08e9287785a0accdb17d

I tried to grab the changes from futurize that matter.

gbremer commented 7 years ago

Got it -- I'll follow your lead there going forward. I assumed you wanted compatibility between py27 and py3, yes? I don't sense the code is at a point where it would suffer by supporting both.

AllenDowney commented 7 years ago

Yes, supporting both is the goal. Thanks!

On Mon, Aug 28, 2017 at 10:37 PM, Grant Bremer notifications@github.com wrote:

Got it -- I'll follow your lead there going forward. I assumed you wanted compatibility between py27 and py3, yes? I don't sense the code is at a point where it would suffer by supporting both.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AllenDowney/ThinkStats2/pull/77#issuecomment-325537996, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy37auvPDUbM_pSPC_V4RQlarIEOy8eks5sc3mBgaJpZM4PFRfu .