search

AllenDowney / plastex-oreilly

Branch of plastex that generates DocBook 4.5 that meets O'Reilly style guidelines.
7 stars 7 forks source link

bug in Imagers/__init__.py #25

Closed AllenDowney closed 12 years ago

AllenDowney commented 12 years ago

In the Dimension class, several of the properties invoke others, but the return values are all strings, so trying to do math with them throws an exception.

I think these are fixed now, and this change should be pulled into the plasTeX distribution.

Tim, if you agree, would you do the pulling?

tiarno commented 12 years ago

I'll work with Kevin on getting the changes in. He's a little swamped right now though. Can we copy the class into the localdefs?

On Thu, Aug 16, 2012 at 2:18 PM, AllenDowney notifications@github.comwrote:

In the Dimension class, several of the properties invoke others, but the return values are all strings, so trying to do math with them throws an exception.

I think these are fixed now, and this change should be pulled into the plasTeX distribution.

Tim, if you agree, would you do the pulling?

— Reply to this email directly or view it on GitHubhttps://github.com/AllenDowney/plastex-oreilly/issues/25.

AllenDowney commented 12 years ago
I am not sure why you want to put it in localdefs. and... I am not sure of copying Dimension into localdefs would work because it gets from...imported.

On Thu, Aug 16, 2012 at 2:24 PM, Tim Arnold notifications@github.comwrote:

I'll work with Kevin on getting the changes in. He's a little swamped right now though. Can we copy the class into the localdefs?

On Thu, Aug 16, 2012 at 2:18 PM, AllenDowney notifications@github.comwrote:

In the Dimension class, several of the properties invoke others, but the return values are all strings, so trying to do math with them throws an exception.

I think these are fixed now, and this change should be pulled into the plasTeX distribution.

Tim, if you agree, would you do the pulling?

— Reply to this email directly or view it on GitHub< https://github.com/AllenDowney/plastex-oreilly/issues/25>.

— Reply to this email directly or view it on GitHubhttps://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7794260.

tiarno commented 12 years ago

yes, of course, I wasn't thinking about the import.

I looked for the changes, but I'm not seeing them. I'm looking at Imager/init.py, class Dimension(float)

but the properties return strings still. https://github.com/oreillymedia/plastex-oreilly/blob/master/plastex/plasTeX/Imagers/__init__.py

and https://github.com/AllenDowney/plastex-oreilly/blob/master/plastex/plasTeX/Imagers/__init__.py

I may just still be confused, feel free to point that out. thanks, --Tim

On Thu, Aug 16, 2012 at 2:44 PM, AllenDowney notifications@github.comwrote:

I am not sure why you want to put it in localdefs. and... I am not sure of copying Dimension into localdefs would work because it gets from...imported.

On Thu, Aug 16, 2012 at 2:24 PM, Tim Arnold notifications@github.comwrote:

I'll work with Kevin on getting the changes in. He's a little swamped right now though. Can we copy the class into the localdefs?

On Thu, Aug 16, 2012 at 2:18 PM, AllenDowney notifications@github.comwrote:

In the Dimension class, several of the properties invoke others, but the return values are all strings, so trying to do math with them throws an exception.

I think these are fixed now, and this change should be pulled into the plasTeX distribution.

Tim, if you agree, would you do the pulling?

— Reply to this email directly or view it on GitHub< https://github.com/AllenDowney/plastex-oreilly/issues/25>.

— Reply to this email directly or view it on GitHub< https://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7794260>.

— Reply to this email directly or view it on GitHubhttps://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7794865.

AllenDowney commented 12 years ago

Yes, they all return strings, but now none of them call each other (which was what was causing the error).

Allen

On Thu, Aug 16, 2012 at 3:30 PM, Tim Arnold notifications@github.comwrote:

yes, of course, I wasn't thinking about the import.

I looked for the changes, but I'm not seeing them. I'm looking at Imager/init.py, class Dimension(float)

but the properties return strings still.

https://github.com/oreillymedia/plastex-oreilly/blob/master/plastex/plasTeX/Imagers/__init__.py

and

https://github.com/AllenDowney/plastex-oreilly/blob/master/plastex/plasTeX/Imagers/__init__.py

I may just still be confused, feel free to point that out. thanks, --Tim

On Thu, Aug 16, 2012 at 2:44 PM, AllenDowney notifications@github.comwrote:

I am not sure why you want to put it in localdefs. and... I am not sure of copying Dimension into localdefs would work because it gets from...imported.

On Thu, Aug 16, 2012 at 2:24 PM, Tim Arnold notifications@github.comwrote:

I'll work with Kevin on getting the changes in. He's a little swamped right now though. Can we copy the class into the localdefs?

On Thu, Aug 16, 2012 at 2:18 PM, AllenDowney notifications@github.comwrote:

In the Dimension class, several of the properties invoke others, but the return values are all strings, so trying to do math with them throws an exception.

I think these are fixed now, and this change should be pulled into the plasTeX distribution.

Tim, if you agree, would you do the pulling?

— Reply to this email directly or view it on GitHub< https://github.com/AllenDowney/plastex-oreilly/issues/25>.

— Reply to this email directly or view it on GitHub<

https://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7794260>.

— Reply to this email directly or view it on GitHub< https://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7794865>.

— Reply to this email directly or view it on GitHubhttps://github.com/AllenDowney/plastex-oreilly/issues/25#issuecomment-7796474.