AllenFang / react-bootstrap-table

A Bootstrap table built with React.js
https://allenfang.github.io/react-bootstrap-table/
MIT License
2.23k stars 782 forks source link

[enhancement] use react-s-alert instead of toastr to alarm some message to user #350

Open seoyoochan opened 8 years ago

seoyoochan commented 8 years ago

[enhancement] use react-s-alert instead of toastr to alarm some message to user

Not only the features of toastr are almost exactly provided by react-s-alert but also it doesn't depend on jQuery.

I used react-s-alert in my client's project and it was easy to use.

Demo: http://react-s-alert.jsdemo.be/ Github: https://github.com/juliancwirko/react-s-alert-demo

staminaloops commented 8 years ago

Hey there, Yes, our goal should be reducing the dependencies.

I'm actually investigating our options:

https://github.com/juliancwirko/react-s-alert

Some modified version of https://github.com/chadly/react-bs-notifier/blob/master/alerts.jsx

Some modified version of https://github.com/k4wo/react-notify/blob/master/index.js

I'll keep updating.

seoyoochan commented 8 years ago

@staminaloops Thank you for your quick response! :heart: I looked trough the options, but i still hold the same suggestion :wink:, which is using react-s-alert because it does not depend on any css framework and focus on providing more rich features than other options. Although the dependencies seem many, they are widely used in real-world development with react. Due to the above reasons, i used it on my prior project. :smile_cat:

staminaloops commented 8 years ago

Np :smile: Yes, the only real dependency is lodash": "4.x.x. I'm actually considering using react-s-alert on my team's project ;) But for react-boostrap-table let me do some more tests and I'll get back to you and @AllenFang.

AllenFang commented 8 years ago

These options is all better than react-toastr, I think we need more test on these options. Thanks! BTW, I can't figure out why react-s-alert need react-hot-loader as dependency(For tweak two different component?)

And react-s-alert depend on Babel@6, I'm afraid of there're some conflict with Babel@5 on development, because we didn't upgrade to babel@6 . However, I think maybe we can upgrade our babel to 6 :)

Finally, we need be more careful for the bundle size on these options :)

seoyoochan commented 8 years ago

@AllenFang I don't understand why the maintainer put react-hot-loader as dep :confused: react-bs-notifier could be an alternative option for react-s-alert because this project is dependent on Bootstrap anyway.

AllenFang commented 8 years ago

@seoyoochan, ok, I'll do some survey on it :+1: And maybe release in near future :)

oeph commented 7 years ago

@AllenFang any updates on this?