search

AllenFang / react-bootstrap-table

A Bootstrap table built with React.js
https://allenfang.github.io/react-bootstrap-table/
MIT License
2.23k stars 782 forks source link

Latest React update causing "unknown props" warnings #590

Closed tylerjryan closed 8 years ago

tylerjryan commented 8 years ago

In the latest version of React, errors are being thrown for "unknown props". See here: https://facebook.github.io/react/warnings/unknown-prop.html

It seems that the BootstrapTable is currently throwing these (as of version 2.3.9): screen shot 2016-07-27 at 9 59 12 am

This seems to have already been resolved by React-Bootstrap, see here: https://github.com/react-bootstrap/react-bootstrap/issues/1994

I just wanted to let you know about this in case you weren't aware. Thanks for the great work!

madeinfree commented 8 years ago

Hi, @tylerjryan, about React-Bootstrap version 0.30.0 was resolved this problem, I can help to change it, Thanks !!

Edit: but must be try some test. I try to update React-Bootstrap to version 0.30.0 but it got broken now, I'll check some reason for it.

quantum-reference commented 8 years ago

Yeah, I'm on 0.30.0 and the latest of react-bootstrap-table as well, and I'm still seeing this issue. Thanks for checking!

madeinfree commented 8 years ago

Hi, @tylerjryan @quantumreference I found this is issue from react-toastr module, I check that issues and have someone intent to fix it ! see Here.

tylerjryan commented 8 years ago

perfect, that makes sense. Thank you very much!

On Wed, Jul 27, 2016 at 7:27 PM Whien notifications@github.com wrote:

Hi, @tylerjryan https://github.com/tylerjryan @quantumreference https://github.com/quantumreference I found this is issue from react-toastr module, I look at that issues and have someone to intent to fix it ! see Here https://github.com/tomchentw/react-toastr/issues/68.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AllenFang/react-bootstrap-table/issues/590#issuecomment-235783497, or mute the thread https://github.com/notifications/unsubscribe-auth/AEtDPJHwiEQZSH6K_OzOT0jqyWFKxzFeks5qaBN8gaJpZM4JWaQI .

AllenFang commented 8 years ago

yes, the problem is from react-toastr

AllenFang commented 8 years ago

Fixed on v2.4.4. Thanks :)

AllenFang commented 8 years ago

there's one thing to notice, on v2.4.4 I move the css files from css to dist folder, remember to update the css path. I apologize for it.