Update and productionize Scientifica 2p dewarping module

wbwakeman commented 4 years ago

Following up on the work in #1130, need to update the Scientifica 2p dewarping module to use Python 3.

Tasks:

[x] Move over from Stash repo to a github repo - ophys_etl_pipelines
[x] Update module
[ ] Add/improve tests
[ ] Check that outputs using the updated module are comparable to previous module
[ ] Confirm that the updated module will run successfully in LIMS (Wayne can help with this one)
[ ] Update LIMS executable to use the container containing these changes

Validation criteria:

[ ] Show evidence that the new module successfully runs and generates correct output
[ ] Demonstrate that new implementation gives 'almost equal' results

Matyasz commented 3 years ago

Oops the pull request is on a different repo so I'm having trouble linking it...

Matyasz commented 3 years ago

Also, before the issue can be officially solved, we will need to make the lims executable updates. It would be great if someone could pair program on that with me since I have never done that before.

wbwakeman commented 3 years ago

Per conversation, removing this from sprint in favor of #115, #116, #117

wbwakeman commented 3 years ago

Closing in favor of #115, #116, #117

AllenInstitute / AllenSDK

Update and productionize Scientifica 2p dewarping module #1726