AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
344 stars 150 forks source link

VBN units table missing left-right ccf coord #2486

Closed corbennett closed 2 years ago

corbennett commented 2 years ago

Describe the bug The current VBN units metadata table has columns for the anterior-posterior CCF coord and the dorsal-ventral coord, but not the left-right coord.

To Reproduce I used the cache from the rc/2.13.5 branch:

from allensdk.brain_observatory.behavior.behavior_project_cache.\
    behavior_neuropixels_project_cache \
    import VisualBehaviorNeuropixelsProjectCache

cache_dir = r"\\allen\programs\mindscope\workgroups\np-behavior\vbn_data_release\vbn_s3_cache"

cache = VisualBehaviorNeuropixelsProjectCache.from_s3_cache(
            cache_dir=cache_dir)

units = cache.get_unit_table()

Expected behavior These coords are also in the channel table, so we should either remove the AP and DV coords from the units table and just make users merge the two tables, or (my preference) we should go ahead and add the left-right coordinate to the units table.