AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
343 stars 149 forks source link

Ophys cells table now supports passed_only filter #2497

Closed aamster closed 2 years ago

aamster commented 2 years ago

Addresses #2242

The issue was that ophys cells table did not filter by passed only, so it was returning more experiments than in the ophys experiments table.

Testing Tested manually to confirm that experiments marked as failed are now excluded when passed_only=True

Note: updating old tests with new ones since updating the old tests would be harder than writing new ones

aamster commented 2 years ago

Need to merge this to avoid merge conflicts. I have addressed your feedback to maintain automated tests on these methods