search

AllenInstitute / AllenSDK

code for reading and processing Allen Institute for Brain Science data
https://allensdk.readthedocs.io/en/latest/
Other
335 stars 149 forks source link

ticket-2543 #2562

Closed morriscb closed 1 year ago

morriscb commented 1 year ago

Add x, y, width, height to ophys_cell_table.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

aamster commented 1 year ago

@morriscb it looks like test data for the ophys cells table needs to be updated. Reminder to use python 3.6 to do the pickling since there's an issue with backwards compatibility

morriscb commented 1 year ago

Fixed the data and now all tests pass.

morriscb commented 1 year ago

Hey @aamster I forgot to add the quick fix for the BehaviorSessionId issue. Take a look if you can and hopefully everything passes again.

Never mind. Tests didn't pass due to pickling errors. I'll open a new ticket to fix the bug.